Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/436 front apply mission action v2 to front ulam pam #440

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Feature/436 front apply mission action v2 to front ulam pam #440

merged 6 commits into from
Nov 22, 2024

Conversation

xtiannyeto
Copy link
Collaborator

  • update types to match back end
  • update action registry over type then mission-action-item
  • update timeline to display new attirbutes
  • refactor control (fish/ nav ) to use new toggle yes/no

@xtiannyeto
feat(overall): apply modification from back
87514ff 
 - update types to match back end
 - update action registry over type then mission-action-item
 - update timeline to display new attirbutes
 - refactor control (fish/ nav ) to use new toggle yes/no
@xtiannyeto
feat(backend): add hasbeen done in control definition
0324c7c 
TODO: add hasBeenDone in entity, model, database
@xtiannyeto xtiannyeto linked an issue Nov 19, 2024 that may be closed by this pull request
Front: Apply mission-action v2 to Front Ulam / PAM #436
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 76.21% (🎯 50%) 1971 / 2586
🟢 Statements 76.1% (🎯 50%) 2051 / 2695
🟢 Functions 73.09% (🎯 50%) 508 / 695
🟢 Branches 68.73% (🎯 50%) 910 / 1324
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/features/common/components/elements/dates/date-picker.tsx 47.36% 35.71% 66.66% 47.36% 27-29, 35-43
frontend/src/features/common/components/elements/dates/daterange-picker.tsx 78.26% 67.74% 40% 78.26% 54-57, 73-88
frontend/src/features/common/types/control-types.ts 100% 100% 100% 100%
Generated in workflow #1339 for commit d1b6e87 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

Overall Project 47.2% ❌

There is no coverage information present for the Files changed

lwih
lwih requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@lwih lwih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changements à effectuer avant de merger, je m'em occupe pendant les vacances de Christian

frontend/src/features/common/types/control-types.ts Outdated Show resolved Hide resolved
@xtiannyeto
fix(env-action): infractions by vessel
12aca89 
 - change output env data infraction to be exacly what is done in v1
@xtiannyeto
feat(env-action): front application of revert to old infraction dto v1
c68f1fb 
 - Apply matching on old infraction dto for env action
@github-actions GitHub Actions
Copy link

Overall Project 47.01% -0.11% ❌
Files changed 61.18% ❌

File Coverage
MissionEnvActionOutput.kt 89.65% -4.24% 🍏
MissionEnvActionDataOutput.kt 44% -0.67% ❌
InfractionEnvDataOutput.kt 0% -9.85% ❌

@github-actions GitHub Actions
Copy link

Overall Project 47.01% -0.11% ❌
Files changed 61.18% ❌

File Coverage
MissionEnvActionOutput.kt 89.65% -4.24% 🍏
MissionEnvActionDataOutput.kt 44% -0.67% ❌
InfractionEnvDataOutput.kt 0% -9.85% ❌

@github-actions GitHub Actions
Copy link

Overall Project 47.01% -0.11% ❌
Files changed 61.18% ❌

File Coverage
MissionEnvActionOutput.kt 89.65% -4.24% 🍏
MissionEnvActionDataOutput.kt 44% -0.67% ❌
InfractionEnvDataOutput.kt 0% -9.85% ❌

@lwih lwih merged commit 126bd84 into main Nov 22, 2024
9 checks passed
@lwih lwih deleted the feature/436-front-apply-mission-action-v2-to-front-ulam--pam branch November 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwih lwih lwih requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Front: Apply mission-action v2 to Front Ulam / PAM
2 participants
@xtiannyeto @lwih