Tech - Amélioration des performances de la requête des PNOs #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
louptheron
commented
Oct 4, 2024
| @@ -68,10 +71,8 @@ class GetPriorNotifications( | |||
| incompletePriorNotifications | |||
| .map { priorNotification -> | |||
| priorNotification.enrich(allRiskFactors, allPorts, priorNotification.isManuallyCreated) | |||
| priorNotification.logbookMessageAndValue.logbookMessage | |||
There was a problem hiding this comment.
On ne calcule pas les noms dans chaque message PNO avant de faire le dernier filtre de pagination
louptheron
commented
Oct 4, 2024
| @@ -137,8 +138,12 @@ class GetPriorNotifications( | |||
| val (enrichedPaginatedList, enrichedPaginatedListTimeTaken) = | |||
| measureTimedValue { | |||
| paginatedList.apply { | |||
| val reportings = getReportings() | |||
There was a problem hiding this comment.
Au lieu de faire X fois la requête findAll, on la fait une seule fois
louptheron
commented
Oct 4, 2024
| .filter { it.isManuallyCreated } | ||
| .mapNotNull { it.logbookMessageAndValue.logbookMessage.vesselId } | ||
| .distinct() |
There was a problem hiding this comment.
On re met pas dans la clause IN les doublons, ça permet d'avoir moins de données à transiter en IN/OUT
ivangabriele
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues