Contrôle - Ajout de champs actionEndDateTime et observationsByUnit
#3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwih
force-pushed
the
action-end-datetime
branch
from
9e0d3b8 to
9099ea6
Compare
ivangabriele
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Pardon pour le temps de réponse !
Côté Frontend et Backend ça m'a l'air good même si je tiens à dire que j'aurais préféré renommer actionDatetimeUtc en actionStartDatetimeUtc du coup pour clarifier les choses mais ça va compliquer les choses en obligeant une nouvelle version de route dans le controller.
- On est bien d'accord que ça ne doit pas s'afficher ni se gérer côté Frontend MonitorFish ? + @louptheron
- C'est mieux que @VincentAntoine valide aussi la PR pour son information côté datascience ;)
louptheron
changed the title
actionEndDateTime et observationsByUnit
louptheron
force-pushed
the
action-end-datetime
branch
from
05407a2 to
1903ad4
Compare
louptheron
approved these changes
Aug 1, 2024
louptheron
force-pushed
the
action-end-datetime
branch
from
4aa04ca to
fedc024
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
actionEndDateTimeetobservationsByUnit#3214/api#3197