-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - Listes] Standardisation des formulaires de filtres #3460
Conversation
65b4634
to
8881831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques remarques et questions.
Test Ko :
La pré sélection de filtre via retour sur fil d'ariane ne fonctionne plus sur :
8881831
to
b2a97fd
Compare
Ok c'est corrigé ! |
524caa5
to
5c4c07d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests ok, quelques suggestions pour le code
assets/scripts/vanilla/controllers/back_auto_affectation_rule/form_auto_affectation_rule.js
Outdated
Show resolved
Hide resolved
09a3e08
to
ec8a562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il reste un petit "account" qui traine. Désolée je ne l'avais pas vu la première fois. Sinon tout le reste est ok. La fonction twig pour le pluriel c'est cool.
Je refais quelques tests
cca4419
to
d99519b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK pour moi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok (ajout d'un mini commit de nettoyage)
|
Ticket
#3376
Description
Standardisation des formulaire de filtres de listes du BO. Utilisation est FormType pour ne plus se poser la question et avoir des trucs gérés aléatoirement.
Changements apportés
Pré-requis
make composer
npm run watch
Tests