Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Signalement] Fil d'Ariane fixé quand on scrolle dans la page #3418

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Dec 9, 2024

Ticket

#3396

Description

Depuis le nouveau menu, les partenaires n'ont plus accès à la référence du signalement en permanence comme avant.
On leur remet à disposition.

Changements apportés

  • Ajout de la référence dans le title de la page
  • Fix du fil d'Ariane en haut de page lorsqu'on scrolle la page (uniquement en version desktop)

Pré-requis

npm run watch

Tests

  • Tester le fonctionnement voulu sur la fiche signalement
  • Vérifier qu'il n'y a pas de changement sur les autres pages
  • Vérifier que le fonctionnement n'est pas appliqué en responsive

@@ -173,12 +182,12 @@ modalsElement.forEach(modalElement => {

document.querySelectorAll('button[data-cloture-type]').forEach(button => {
button.addEventListener('click', (e) => {
const element = e.target;
const element = e.target
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter

@@ -216,10 +216,6 @@ legend.required::after, label.required::after {
display: inline-flex !important;
}

.fr-display-block {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suppression doublon règle

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça marche super bien, juste une petite remarque

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@emilschn emilschn force-pushed the feature/3396-fixed-menu branch from 4abdc39 to 7f4ef29 Compare December 10, 2024 13:22
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit 5f09550 into develop Dec 10, 2024
4 checks passed
@emilschn emilschn deleted the feature/3396-fixed-menu branch December 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants