-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Signalement] Enregistrement de l'identifiant BAN #3345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques remarques et proposition dans le code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests OK
5f3b25f
to
1c2f1cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Une petite remarque sur le paramètre limite
@@ -88,7 +88,7 @@ export function attacheAutocompleteAddressEvent (inputAdresse) { | |||
addressGroup.innerHTML = '' | |||
selectionIndex = -1 | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter js...
const buttonElement = document.getElementById('tabpanel-'+currentHash) | ||
const tabElement = document.getElementById('tabpanel-'+currentHash+'-panel'); | ||
if(buttonElement && tabElement){ | ||
const currentHash = window.location.hash !== '' ? window.location.hash.substring(1) : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter js...
98b41a9
to
4efef2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test KO : La géoloc et toujours enregistré sur CP+Commune au lieu de l'adresse complète.
J'ai commenté selon ma vision mais il y'a sûrement d'autre manière de faire.
a8dc92b
to
5fbbf4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
|
Ticket
#3322
Description
Afin de mieux s'interfacer avec d'autres SI, on enregistre l'identifiant retourné par la BAN qui correspond à un regroupement entre le code INSEE de la commune, un code pour la voie, et le numéro sur la voie.
Changements apportés
Pré-requis
npm run watch
make composer
make execute-migration name=Version20241125151642 direction=up
Tests
make console app="init-id-ban"