[QA - Sentry] setKey on Array / TypeError

src/Controller/FrontSignalementController.php

@@ -138,10 +138,12 @@ public function handleUpload(
         if (null !== ($files = $request->files->get('signalement'))) {
             try {
                 foreach ($files as $key => $file) {
-                    $res = $uploadHandlerService->toTempFolder($file)->setKey($key);
-                    if (!isset($res['error'])
-                        && \in_array($file->getMimeType(), ImageManipulationHandler::IMAGE_MIME_TYPES)
-                    ) {
+                    $res = $uploadHandlerService->toTempFolder($file);
+                    if (\is_array($res) && isset($res['error'])) {
+                        throw new \Exception($res['error']);
+                    }
+                    $res = $uploadHandlerService->setKey($key);
+                    if (\in_array($file->getMimeType(), ImageManipulationHandler::IMAGE_MIME_TYPES)) {
                         $imageManipulationHandler->resize($res['filePath'])->thumbnail();
                     }
 
@@ -202,11 +204,13 @@ public function envoi(
             $signalement = new Signalement();
             $dataDateBail = $dataHasDPE = $dataDateDPE = $dataConsoSizeYear = $dataConsoSize = $dataConsoYear = null;
             $listNDECriticites = [];
-
             if (isset($data['files'])) {
                 $dataFiles = $data['files'];
                 foreach ($dataFiles as $key => $files) {
                     foreach ($files as $titre => $file) {
+                        if (\is_array($file)) {
+                            continue;
+                        }
                         $filename = $uploadHandlerService->moveFromBucketTempFolder($file);
                         $file = $fileFactory->createInstanceFrom(
                             filename: $filename,

tests/Functional/Service/UploadHandlerServiceTest.php

@@ -11,6 +11,7 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\HttpFoundation\File\Exception\FileException;
 use Symfony\Component\HttpFoundation\File\UploadedFile;
 
 class UploadHandlerServiceTest extends KernelTestCase
@@ -108,6 +109,34 @@ public function testUploadBigFileShouldThrowsException(): void
         $uploadHandlerService->uploadFromFile($uploadedFileMock, 'test.png');
     }
 
+    public function testUploadToTempFolderThrowException(): void
+    {
+        $uploadFile = new UploadedFile(
+            $this->projectDir.$this->fixturesPath.$this->targetFilename.$this->extension,
+            $this->targetFilename,
+            'image/png',
+            null,
+            true
+        );
+
+        $this->filesystemOperator
+        ->expects($this->once())
+        ->method('writeStream')
+        ->willThrowException(new FileException());
+
+        $uploadHandlerService = new UploadHandlerService(
+            $this->filesystemOperator,
+            $this->parameterBag,
+            $this->logger,
+            $this->heicToJpegConverter,
+            $this->filenameGenerator,
+        );
+
+        $uploadHandler = $uploadHandlerService->toTempFolder($uploadFile);
+        $this->assertIsArray($uploadHandler);
+        $this->assertArrayHasKey('error', $uploadHandler);
+    }
+
     /*public function testUploadFromFilename(): void
     {
         $this->heicToJpegConverter