[bug] La commande de maj des commune ne dépends plus des fixtures #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sfinx13
reviewed
Jan 12, 2024
Comment on lines
+16
to
+23
| $codeCommune = $itemCodeCommune; | ||
| $codeCommune = str_pad($codeCommune, 5, '0', \STR_PAD_LEFT); | ||
| $zipCode = substr($codeCommune, 0, 2); | ||
| if ('97' == $zipCode) { | ||
| $zipCode = substr($codeCommune, 0, 3); | ||
| } | ||
|
|
||
| return $zipCode; |
There was a problem hiding this comment.
Pour le zipCode de la Corse c'est 2A et 2B voir du coté de https://github.com/MTES-MCT/histologe/blob/main/src/Service/Signalement/ZipcodeProvider.php
A moins que code Commune correspondent à code insee ?
There was a problem hiding this comment.
c'est bon j'ai ma réponse j'approuve
sfinx13
approved these changes
Jan 12, 2024
Comment on lines
+16
to
+23
| $codeCommune = $itemCodeCommune; | ||
| $codeCommune = str_pad($codeCommune, 5, '0', \STR_PAD_LEFT); | ||
| $zipCode = substr($codeCommune, 0, 2); | ||
| if ('97' == $zipCode) { | ||
| $zipCode = substr($codeCommune, 0, 3); | ||
| } | ||
|
|
||
| return $zipCode; |
There was a problem hiding this comment.
c'est bon j'ai ma réponse j'approuve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2107
Description
Fix de la commande update-communes afin qu'elle ne dépende plus du DoctrineFixtureBundle
Tests
make load-fixturesmake console app="update-communes"