Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] unpkg plus fiable #2461

Closed
hmeneuvrier opened this issue Apr 12, 2024 · 1 comment · Fixed by #2462
Closed

[QA] unpkg plus fiable #2461

hmeneuvrier opened this issue Apr 12, 2024 · 1 comment · Fixed by #2462
Labels
Milestone

Comments

@hmeneuvrier
Copy link
Collaborator

hmeneuvrier commented Apr 12, 2024

Aujourd'hui unpkg a eu des soucis sur quelques librairies. (m^me la page de status renvoie un erreur 520 https://www.unpkg.com/status/)
https://mattermost.incubateur.net/betagouv/pl/bkhybcontid93bnep4dwgskeyy
https://mattermost.incubateur.net/betagouv/pl/mduoy8aaztdx7msheopiod9hyh

En cherchant un peu je suis tombée sur des messages sur https://github.com/mjackson/unpkg :
issues/383
issues/385

Le premier met en lumière que unpkg ne semble plus maintenant depuis décembre 2021, le deuxième préconise de passer sur jsdelivr :

Consider switching to a production focused CDN https://cdn.jsdelivr.net/npm/react@18/umd/react.production.min.js
Tool for easy conversion https://www.jsdelivr.com/unpkg

J'ai donc utilisé l'outil de conversion pour passer sur jsdelivr, mais j'ai des erreurs sur tippy...

En profiter pour ne plus charger leaflet (js et css) sur la page de signalement.

@hmeneuvrier hmeneuvrier changed the title [QA] Ne plus charger leaflet (js et css) sur la page de signalement. Quid de popperjs ? [QA] unpkg plus fiable Apr 12, 2024
hmeneuvrier added a commit that referenced this issue Apr 12, 2024
@hmeneuvrier
Copy link
Collaborator Author

Solution trouvée sur https://github.com/atomiks/tippyjs/issues

I've used the following which has sorted it for me:
<script src="https://cdn.jsdelivr.net/npm/@popperjs/[email protected]/dist/umd/popper.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/tippy.js@6/dist/tippy-bundle.umd.js"></script>

hmeneuvrier added a commit that referenced this issue Apr 12, 2024
@hmeneuvrier hmeneuvrier linked a pull request Apr 12, 2024 that will close this issue
2 tasks
hmeneuvrier added a commit that referenced this issue Apr 15, 2024
@sfinx13 sfinx13 added the v2.2.0 label May 7, 2024
@mathildepoulpux mathildepoulpux added this to the v2.2.0 milestone Jun 5, 2024
@mathildepoulpux mathildepoulpux moved this from Prêt pour la MEP to Released in Produit Histologe 🏡 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: En prod
Development

Successfully merging a pull request may close this issue.

3 participants