chore(food,textile,api)!: Remove deprecated API endpoints. #951
+1,205
−2,210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
from
2348cd0 to
570c621
Compare
n1k0
changed the title
|
Updated patch, title and description to remove the query-string based endpoints completely because we don't need a deprecation step as we have API versioning to circumvent that. |
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
4 times, most recently
from
9d73804 to
3ae6244
Compare
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
from
b3c579f to
e0aea47
Compare
|
Switching back to Draft because this depends on #954 to land first. |
n1k0
changed the title
vjousse
pushed a commit
that referenced
this pull request
Mar 4, 2025
## 🔧 Problem Query-string based API endpoints have been complicated to maintain over time and don't provide much value over their much simpler POST+JSON equivalent. We should deprecate these redundant GET endpoints. Note: We'll remove them completely in the following major version to clear redundancy and clean a bunch of tech debt along the way (work has been started in #951). ## 🍰 Solution Deprecate these API endpoints which already have a POST+JSON equivalent: - `GET /food` - `GET /textile/simulator` - `GET /textile/simulator/{impact}` - `GET /textile/simulator/detailed` These will be removed in 5.0.0. ## 🏝️ How to test Endpoints should keep working, only the documentation should denote them as deprecated: 
This reverts commit 4cfbad1.
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
from
e0aea47 to
e89bcff
Compare
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
from
1362e6f to
85c737c
Compare
n1k0
force-pushed
the
chore/deprecate-query-string-based-endpoints
branch
from
2b0e8ea to
92c26a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problems
GET+ query string endpoints completely following deprecation started in 4.0.0 (chore: deprecate textile simulator API GET endpoints. #954).🍰 Solution
GET /foodGET /textile/simulatorGET /textile/simulator/{impact}GET /textile/simulator/detailed⏰ Watch out
This patch clears a bunch of tech debt by introducing a dedicated, isolated layer of validation, independent from decoding.
🏝️ How to test