Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Check-UpdateComplianceSetting.ps1 #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Check-UpdateComplianceSetting.ps1 #43

wants to merge 2 commits into from

Conversation

baardhermansen
Copy link

  • Replaced the WMI calls with one call and use of a variable
  • There were multiple logical errors in if statements. The if logic allowed both empty and non-empty values, effectively never reaching the else condition
  • Switched to an easier method to check for empty string in if statements
  • Corrected logical error in function CheckUtcCsp. It would report Passed if registry value did not exist.

@baardhermansen
Update Check-UpdateComplianceSetting.ps1
e503196 
- There were multiple logical errors in if statements. The if logic allowed both empty and non-empty values, effectively never reaching the else condition. Corrected all of them and also switched to a slightly easier method to check for empty string.
- Corrected logical error in function CheckUtcCsp. It would report Passed if registry value did not exist.
@baardhermansen
Copy link
Author

Review needed ;) @JankeSkanke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baardhermansen