Partials: Correctly set the HtmlFieldPrefix of the partial view

[fsateler]

Otherwise IdFor and friends do not work as expected because the view prefix is empty.

This also has the advantage of not replacing the user FieldGenerator for the view.

--

Before this patch, if you have the following:

@* Parent.cshtml *@
@using (var f = Html.BeginChameleonForm()) {
     using (var s = f.BeginSection("Fields")) {
           @s.PartialFor(m => m.ChildProperty)
     }
}

@* ChildProperty.cshtml *@

@this.FormSection().FieldFor(c => m.Integer)

<script>console.log($('#@Html.IdFor(m => m.Integer)').length)</script>

The javascript console will print 0, because the id of the Integer field is ChildProperty_Integer but IdFor returned Integer.

After the patch the console will print 1, as expected.

[fsateler]

ping

This also has the advantage of not replacing the user FieldGenerator for the view.

I just noted that this (replacing the user FieldGenerator) makes this feature unusable for my use case, becase I have several non-default handlers.

[robdmoore]

This is a good change, but I'm wondering if we need to write a test to cover the bug it's fixing first?

[robdmoore]

I'm doing this as part of some other work I'm doing to fix a bug in Partial.

[fsateler]

Indeed, tests would be nice. I'll try to get something and submit it.

[fsateler]

Oh you already did that in #155. Thanks! Saludos, Felipe Sateler

…

On Jan 28, 2017 13:01, "Rob Moore" ***@***.***> wrote: I'm doing this as part of some other work I'm doing to fix a bug in Partial. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#152 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQsHYnNMpdhqIGfPEZ5VdctQ8Ww4SCaks5rW2ZhgaJpZM4K_klS> .