-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HtmlAttributes.ToString that renders the html #135
Conversation
Otherwise you end up with weird stuff like: `form.Write(navigation.Submit("text")` rendering `ChameleonForms.Component.ButtonHtmlAttributes`
I'm very comfortable pulling this in, but I'm very curious about why you are using |
Add HtmlAttributes.ToString that renders the html
Well, a lot of my forms have just a single button. So I created an extension method that basically does:
But then I had the class name printed instead of a button ;) |
Another way is to get your extension method to return the IHtmlString from f.Submit() That way you don't need to call Writr and you retain control of the output stream within your razor file.
|
Ah, that makes sense. BTW, is there an ETA or a list of issues to be finished before we get a new release? I don't see milestones in the issue tracker. |
I'm just waiting for a PR review of #132 from @MattDavies and then we will release 2.0. |
OK, thanks On 28 October 2015 at 13:20, Rob Moore [email protected] wrote:
Saludos, |
FWIW, the suggestion didn't work, because the Navigation.Dispose method also writes to the stream directly, and thus the button ends outside the navigation section. |
Ahh right of course. Good catch.
|
Otherwise you end up with weird stuff like:
form.Write(navigation.Submit("text")
renderingChameleonForms.Component.ButtonHtmlAttributes