Fixing a NullReferenceException, probably only occuring in MVC5 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code path of ValidationMessageFor under MVC5.
robdmoore
added a commit
that referenced
this pull request
Aug 6, 2015
Fixing a NullReferenceException, probably only occuring in MVC5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FieldConfigurationreturned from aValidationMessageForwould throw on it'sToHtmlStringcall made by Razor.The reason is that the
_fieldmember evaluates down to a call toHtmlHelper.ValidationMessageForfromSystem.Web.Mvcand, at least in MVC5, that returnsnullwhen there is no message to be had - which is most of the time.I didn't research in what exactly the difference to the test project is that it makes the bug surface for me, but the MVC version difference is the one obvious suspect.
The suggested little addition of robustness fixes things for me.