Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify the radius of the Earth #95

Merged
merged 1 commit into from
May 4, 2021

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 29, 2021

We want to stay with the Earth radius from CIME used throughout compass, not the one in MPAS-Ocean.

closes #61

We want to stay with the Earth radius from CIME used throughout
compass, not the one in MPAS-Ocean.
@xylar xylar added ocean clean-up python package DEPRECATED: PRs and Issues involving the python package (master branch) labels Apr 29, 2021
@xylar xylar self-assigned this Apr 29, 2021
@xylar
Copy link
Collaborator Author

xylar commented Apr 29, 2021

This is a change that @proteanplanet requested quite a long time ago. We want to make sure that the CIME Earth radius is used consistently throughout the E3SM mesh generation process. This has already happened for steps that are in MPAS-Tools and compass but MPAS-Model has been renormalizing the sphere radius to its own internal value.

It would still be good if MPAS-Ocean's internal Earth radius were made the same as CIME's because some parameterizations use the Earth radius form MPAS-Model. But with this change, the mesh should retain the CIME Earth radius.

Copy link
Collaborator

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@xylar
Copy link
Collaborator Author

xylar commented May 4, 2021

Thanks @mark-petersen and @vanroekel!

@xylar xylar merged commit 1186b9b into MPAS-Dev:master May 4, 2021
@xylar xylar deleted the do_not_expand_earth_sphere branch May 4, 2021 19:49
@xylar xylar removed the request for review from proteanplanet May 4, 2021 19:49
xylar added a commit to xylar/compass that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up ocean python package DEPRECATED: PRs and Issues involving the python package (master branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure we set config_expand_sphere = .false. in compass 1.0
3 participants