Added cubed_sphere target grid test to utility/combine_topo
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
reviewed
Sep 26, 2024
There was a problem hiding this comment.
@bmooremaley, this is excellent work! I'm very happy with the way you have reorganized things and the clean-up you've done along the way.
I have some suggested changes that we can discuss today.
|
Presumably, you'll need to do a commit to make the linter happy. The easiest way to do that is probably to add an extra newline somewhere (maybe at the end of the file) and then fix whatever it complains about. Make sure you do that with the conda environment loaded so pre-commit can happen. |
…ine_topo, nearing complete workflow for pull request
…nd cubed_sphere remapping cases, and successfully ran for 0.1 deg and ne30 target grids
bmooremaley
force-pushed
the
combine-topo-to-cubedsphere
branch
from
b94f7d9 to
1ed573a
Compare
xylar
reviewed
Oct 9, 2024
| descriptor = get_lat_lon_descriptor( | ||
| dLon=self.resolution, dLat=self.resolution, | ||
| ) | ||
| descriptor.to_scrip(out_filename) |
There was a problem hiding this comment.
Need to make sure this is in NETCDF3 format. This should be possible by setting the .format argument in the descriptor (see pyremap for details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ocean/utility/combine_topotest has been split into two separate tests: one for alat_lontarget grid and one for acubed_spheretarget grid. Thecubed_spheretest allows the migration tombtempestfor remapping bathymetry to MPAS grids by removing the pole singularities. The workflow for the existinglat_lontarget grid has also been updated to use remapping tools more consistently between the GEBCO and BedMachineAntarctica data sets, and between thelat_lonandcubed_spheretarget mesh workflows. Specifically, the GEBCO dataset is separated into tiles prior to remapping,ESMF_RegridWeightGenis used for building weights files, andncremapis used for the final remapping step.Checklist
Testingin this PR) any testing that was used to verify the changes