Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mesh: SOwISC12to30E3r4 #829

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

New Mesh: SOwISC12to30E3r4 #829

wants to merge 11 commits into from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jun 10, 2024

Long name: SOwISC12to30kmL80E3SMv3r4

This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:

  • 12 km resolution around Antarctica
  • 30 km elsewhere

It is intended to be similar to the Icos30 mesh except in the Southern Ocean and around Antarctica.

This mesh differs from r3 in #807 in that:

  • MALI topography as well as masks for land ice, floating ice and ocean get combined with BedMachine Antarctica/GEBCO.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging E3SM PR required labels Jun 10, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jun 10, 2024

This is based off of #807 (which is based off of #813) so it will be a bit before this is ready to go in. It also needs documentation.

@xylar xylar force-pushed the add-mali-topo branch 3 times, most recently from 0b54306 to 959da20 Compare June 12, 2024 16:17
@xylar
Copy link
Collaborator Author

xylar commented Jun 12, 2024

Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI topography:
mali_topo_land_ice_mask

And the same but with BedMachine from #807:
sowiscr3_land_ice_mask

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from be2486f to b5e6880 Compare July 8, 2024 12:36
@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI (AIS_2to10km) topography:
sorrm_ais_2to10km_land_ice_mask

And the same but with BedMachine from #807:
sorrm_r3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions.

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from e512590 to 824f8f5 Compare July 26, 2024 09:31
xylar added 7 commits October 22, 2024 09:37
MALI topogrpahy gets combined with BedMachine Antarctica/GEBCO.

For now, the masks for the grounding line, calving front, etc.
are form BedMachine, not MALI, so that the same horizontal mesh
and mapping files can be used with BedMachine and MALI topogrpahy.
These will change the locaiton of the grounding line and calving
front, so that the resulting ocean grid will be different from
the equivalent from BedMachine.
Move ocean_density and sea_level to config options
@xylar xylar changed the title Add a step for remapping topography from MALI New Mesh: SOwISC12to30E3r4 Oct 22, 2024
@xylar xylar added the new mesh An E3SM mesh for special review label Oct 22, 2024
@xylar xylar marked this pull request as ready for review October 22, 2024 18:44
@xylar xylar added sea ice and removed in progress This PR is not ready for review or merging labels Oct 22, 2024
@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

Another Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM r4 mesh with MALI (AIS_4to20km) topography:
sorrmr4_land_ice_mask

And the same but SORRM r3 with BedMachine topography from #807:
sorrmr3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

The same as above but zooming in on the Amundsen Sea.

SORRM r4:
sorrmr4_amundsen

SORRM r3:
sorrmr3_amundsen

@cbegeman
Copy link
Collaborator

@xylar have you been looking at all at landIceFloatingFraction?

@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

Not yet. I should.

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2024

landIceFloatingFraction

SORRM r4

sorrmr4_land_ice_floating_fraction

SORRM r3

sorrmr3_land_ice_floating_fraction

@cbegeman, no surprises to me. What do you think?

@cbegeman
Copy link
Collaborator

@xylar Thanks for sharing those.

The new map is nice in that the "shadow" islands of floating ice are removed near the peninsula.

It looks like not all the cells near the coastline are capped at 0.5. Isn't that supposed to be the case? Or is that only true when there's grounded ice upstream as opposed to exposed rock?

What do you think of the pocket of partial ice cover at Brunt near an island? I'm thinking that since it's part of the ice mask there won't be sea ice formation. And there also won't be any interaction with the atmosphere, right (like fluxes scaled by the ice fraction)? We could potentially get a bit of frazil there since frazil doesn't change the surface pressure. But I don't know if this is really worth worrying about. Should we look at the land ice pressure field and make sure that that's reasonably smooth. I see one other low fraction "island" between Ross and Getz.

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2024

It looks like not all the cells near the coastline are capped at 0.5. Isn't that supposed to be the case? Or is that only true when there's grounded ice upstream as opposed to exposed rock?

No that's no longer the case. That was a change with r3. I think we want to allow melting in partial open ocean, partial ice-shelf cells for conservation. Otherwise, we need to reroute the missing melt somewhere else. When melt is happening in the coupler, this will presumably be happening anyway so this is to make melt computed in MPAS-Ocean more similar to what will happen in the coupler.

@cbegeman
Copy link
Collaborator

@xylar That's ringing some bells. Thanks for the reminder

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2024

What do you think of the pocket of partial ice cover at Brunt near an island? I'm thinking that since it's part of the ice mask there won't be sea ice formation. And there also won't be any interaction with the atmosphere, right (like fluxes scaled by the ice fraction)? We could potentially get a bit of frazil there since frazil doesn't change the surface pressure. But I don't know if this is really worth worrying about. Should we look at the land ice pressure field and make sure that that's reasonably smooth. I see one other low fraction "island" between Ross and Getz.

These are presumably places where isolated pockets of open ocean have been filled in because they're not resolved enough. Frazil could certainly form here but I would expect these mostly to be pretty passive areas. You could be right though that it's worth looking at ice draft or land-ice pressure here to make sure these areas don't look too weird. They could be isolated pockets of essentially zero-thickness ice shelf where water just gets trapped.

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2024

The files are in:

/lcrc/group/e3sm/ac.xylar/compass_1.5/chrysalis/e3smv3-meshes/sowisc12to30e3r4/ocean/global_ocean/SOwISC12to30/MALI_topo_AIS_4to20km/

and also staged for testing in:

/lcrc/group/e3sm/data/inputdata/ocn/mpas-o/SOwISC12to30E3r4

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2024

I will make a proper review page soon.

@xylar
Copy link
Collaborator Author

xylar commented Oct 25, 2024

@matthewhoffman found issues with thickness in the dataset we are using from MALI. I'll need to rerun once that's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E3SM PR finished enhancement New feature or request new mesh An E3SM mesh for special review ocean sea ice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants