Add wave mesh generation for global_ocean mesh test cases #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids end of file error in namelist read
|
@sbrus89, I had the impression you would ping me when this is ready to review. Just wanted to check that I hadn't missed that ping. |
- This means Antarctic coastline is between ocean and ice instead of ocean and grounding line
- Also add the ability to (optionally) specify paths to existing base and culled ocean meshes in the config file
erinethomas
force-pushed
the
waves_mesh
branch
from
b725704 to
acc78b6
Compare
erinethomas
reviewed
Sep 11, 2024
| data = np.loadtxt('angled.d') | ||
| angled = data[:, 2] | ||
|
|
||
| filename_local_in = 'obstructions_local.waves_mesh_culled.in' |
There was a problem hiding this comment.
file can't be found. The file is placed in output directory ... suggest changing the file name to be 'output/obstructions_local.waves_mesh_culled.in'
erinethomas
reviewed
Sep 11, 2024
| self.write_alpha_beta(filename_local_out, header, nodes, lon_local, lat_local, sizes, alpha_interp, beta_interp) | ||
| self.plot_alpha_beta_spectra(Theta, Freq, alpha_spec, beta_spec, alpha_interp, beta_interp, angled, nodes, 'local') | ||
|
|
||
| filename_shadow_in = 'obstructions_shadow.waves_mesh_culled.in' |
There was a problem hiding this comment.
again, file can't be found. The file is placed in output directory ... suggest changing the file name to be 'output/obstructions_shadow.waves_mesh_culled.in'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collaboration with @erinethomas that adds the workflow used to create coastal-refined wave mesh that conforms to the coastlines for a given ocean mesh. It includes several steps to:
This work depends on the MPAS-Tools PR: MPAS-Dev/MPAS-Tools#579
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes