Clean up iceshelf framework
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
cbegeman
approved these changes
Apr 29, 2024
don't use camel case variable names move some common calculations outside the iterative loop
xylar
force-pushed
the
clean-up-iceshelf-framework
branch
from
c164f5d to
f161a60
Compare
|
I tried testing this on Chrysalis on Friday and was getting unexpected non-BFB results in tests without ice-shelf cavities. I think it may be just the Chrysalis weirdness that we have been experiencing lately. I'm going to wait until #810 has gone in because I'm hoping that will fix the issues. |
TestingI ran the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some clean up needed to make SSH adjustment in the
iceshelfframework work for adjusting SSH instead of land-ice pressure.This was pulled out of #813 because that work no longer uses the
iceshelfframework.Checklist
Testingin this PR) any testing that was used to verify the changes