Fix landice/antarctica/mesh_gen
#730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8b327bd, which inadvertently broke the `landice/antarctica/mesh_gen` case and could lead to unexpected behavior elsewhere.
TestingThe mesh created using the current head of Using this branch results in the expected behavior: |
xylar
reviewed
Nov 13, 2023
Comment on lines
+532
to
+535
| flood_mask = gridded_flood_fill(thk) | ||
| thk[flood_mask == 0] = 0.0 | ||
| vx[flood_mask == 0] = 0.0 | ||
| vy[flood_mask == 0] = 0.0 |
There was a problem hiding this comment.
I don't understand why the original change didn't work. I would think it would be identical to the following, which would be identical to the code after reversion.
flood_mask = gridded_flood_fill(thk)
mask = (flood_mask == 0)
thk[mask] = 0.0
vx[mask] = 0.0
vy[mask] = 0.0But it's not worth exploring further.
xylar
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8b327bd, which inadvertently broke the
landice/antarctica/mesh_gencase and could lead to unexpected behavior elsewhere.Checklist
Testingin this PR) any testing that was used to verify the changesThis closes #729.