Replace init mode in drying slope test cases

[cbegeman]

This PR replaces the mode_init MPAS-Ocean run in the initial_state step with local computations. The initial state is unchanged for the configuration that is currently used in the drying_slope cases. I did not retain all of the configuration options that were previously present in mode_init, e.g., the idealized transect.

I added some buffer space in the y-dimension (the new config options Ly as differentiated from Ly_analysis) because the 1km case did not include the full 25km stretch of wetting and drying.

Checklist

• User's Guide has been updated
• Developer's Guide has been updated
• Documentation has been built locally and changes look as expected
• Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

[cbegeman]

Testing

Drying slope tests have been run on chrys with intel, impi. Results are qualitatively similar by visual inspection. Before the domain size was changed, the initial state was also verified to be quantitatively similar

[xylar]

I'm not super involved with the drying slope test case so I'm mostly leaving the review of the details to @sbrus89. The approach here looks great to me! I'm always in favor of moving away from init mode.

[cbegeman]

@sbrus89 FYI, I'm going to add coriolis parameter as a config option if you want to hold off reviewing.

[cbegeman]

@sbrus89 Ready for your review. Thanks!

[sbrus89]

@cbegeman, would you mind rebasing this now that #703 is merged?

[cbegeman]

@sbrus89 No problem. I'll ping you once I've rebased and retested.

[sbrus89]

Thanks very much!

[cbegeman]

@sbrus89 Ready for your review!

[cbegeman]

@sbrus89 Just a reminder to review this when you have the chance

[sbrus89]

Thanks @cbegeman, sorry for losing track of this.

[sbrus89]

@cbegeman, this looks great and is a huge improvement over the init mode config. I had a couple minor comments. Also, I did notice in testing that the convergence seems to have been altered:

baseline:

this pr:

[cbegeman]

@cbegeman, this looks great and is a huge improvement over the init mode config. I had a couple minor comments. Also, I did notice in testing that the convergence seems to have been altered:

Let me look into this. The change shouldn't have been this large. I may have forgotten to take into account the (new) domain offset when we evaluate convergence.

[cbegeman]

Yep, as I suspected in the rebase I forgot to add the yCell offset to the analysis step of the convergence test. Now the convergence plot is the same as before:

[cbegeman]

@sbrus89 Thanks for your thorough review! I have now addressed all your comments. Let me know if you spot anything else.

[sbrus89]

@cbegeman, this looks great. Thanks for the effort on this!

[cbegeman]

@xylar This is ready to merge. Do I have the go-ahead from you?

[xylar]

Yep, go for it!

[xylar]

(You don't need to ask me if the PR is assigned to you, you can just merge. But I appreciate you checking!)

[cbegeman]

@xylar Thanks! I wanted to check because I assigned it to myself :)

[xylar]

Ah, yeah, fair enough. You have my blanket permission to assign yourself and merge when you see fit :-)