Add double quotes to flag #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xylar do you prefer to be the person to merge all the compass PRs? Or do you want me to merge little ones like this after they are approved? |
|
@mark-petersen, you can merge once @cbegeman has approved. Sorry I missed this in the testing I did on #551. There were expected non-bit-for-bit baseline comparison failures but I guess the actual test failures snuck past me in the process. |
cbegeman
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python, string flag specifications require both single and double quotes. This fixes the recent
config_implicit_bottom_drag_typeaddition. This broke all thedynamic_adjustmentcases, and specificallyocean/global_ocean/QU240/WOA23/dynamic_adjustmentin theprsuite. This works now.