Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config section name for humboldt_mesh #384

Merged
merged 1 commit into from
May 4, 2022

Conversation

trhille
Copy link
Collaborator

@trhille trhille commented May 4, 2022

Change config section name from humboldt to humboldt_mesh. This was
causing the mesh_gen test case to fail.

Change config section name from humboldt to humboldt_mesh. This was
causing the mesh_gen test case to fail.
@trhille trhille requested a review from xylar May 4, 2022 20:23
@xylar xylar added the bug Something isn't working label May 4, 2022
@xylar xylar added the land ice label May 4, 2022
@xylar
Copy link
Collaborator

xylar commented May 4, 2022

Seems to have snuck through testing in #318.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trhille, as long as you can post something about testing that failed without this and passes with it, it's an obvious fix.

@trhille
Copy link
Collaborator Author

trhille commented May 4, 2022

When using master, the Humboldt mesh generation case failed:

(compass_spack_albany) 14:42:52 trhille@ba023 /lustre/scratch4/turquoise/trhille/Humboldt_mesh_20220404_originmaster$compass run
landice/humboldt/mesh_gen
  * step: mesh
      Failed
  test execution:      ERROR
  see: case_outputs/landice_humboldt_mesh_gen.log
  test runtime:        00:09
Test Runtimes:
00:09 FAIL landice_humboldt_mesh_gen
Total runtime 00:09
FAIL: 1 test failed, see above.

case_outputs//landice_humboldt_mesh_gen.log shows that the error is due to an call to a section of the config file called humboldt, which was changed to humboldt_mesh in #318:

Exception raised in run()
Traceback (most recent call last):
  File "/turquoise/usr/projects/climate/trhille/compass/compass/run/serial.py", line 130, in run_tests
    test_case.run()
  File "/turquoise/usr/projects/climate/trhille/compass/compass/testcase.py", line 162, in run
    self._run_step(step, self.new_step_log_file)
  File "/turquoise/usr/projects/climate/trhille/compass/compass/testcase.py", line 278, in _run_step
    step.run()
  File "/turquoise/usr/projects/climate/trhille/compass/compass/landice/tests/humboldt/mesh.py", line 67, in run
    cell_width, x1, y1, geom_points, geom_edges = self.build_cell_width()
  File "/turquoise/usr/projects/climate/trhille/compass/compass/landice/tests/humboldt/mesh.py", line 215, in build_cell_width
    cell_width = set_cell_width(self, section='humboldt', thk=thk,
  File "/turquoise/usr/projects/climate/trhille/compass/compass/landice/mesh.py", line 151, in set_cell_width
    section = self.config[section]
  File "/usr/projects/climate/trhille/miniconda3/envs/compass_spack_albany/lib/python3.9/site-packages/mpas_tools/config.py", line 420, in __getitem__
    return self.combined[section]
  File "/usr/projects/climate/trhille/miniconda3/envs/compass_spack_albany/lib/python3.9/configparser.py", line 963, in __getitem__
    raise KeyError(key)
KeyError: 'humboldt'

After implementing this change:

landice/humboldt/mesh_gen
  * step: mesh
  test execution:      SUCCESS
  test runtime:        03:34
Test Runtimes:
03:34 PASS landice_humboldt_mesh_gen
Total runtime 03:34
PASS: All passed successfully!

@trhille trhille merged commit 8f95f0d into MPAS-Dev:master May 4, 2022
@xylar
Copy link
Collaborator

xylar commented May 4, 2022

Thanks for fixing this, @trhille!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working land ice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants