Add FRIS comparison grid #1071
Merged
Add FRIS comparison grid #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! I'll give it a couple of quick tests tomorrow and then merge if things work as expected. |
|
Regarding documentation, https://github.com/MPAS-Dev/MPAS-Analysis/blob/develop/docs/users_guide/config/comparison_grids.rst is so woefully out of date that it doesn't make sense to try to fix it here. |
|
I ran the test suite and things look good: I pushed a commit that adds the Fris comparison grid to the test suite. @irenavankova, I hope that's fine with you. |
xylar
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to make plots on a grid that focuses on the Filchner-Ronne cavity.
Here is an example bsf plot with that option:
