Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and minor CI bug fixes #1045

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Dec 19, 2024

In this PR, I fixed a few minor issues:

  1. The docs CI workflow was trying to reference a nonexistent variable to set the python version. I've changed this to reference a variable local to this file which will have to be manually changed if we want to build the docs in a later version of python (it's currently set to 3.10).
  2. The build workflow was being skipped in relation to changes made in the setup.py file, but this should have been changed to pyproject.toml during Migrate setup procedures to pyproject.toml #1044
  3. I added the fail-fast attribute to the build workflow so that jobs won't cancel other jobs if they fail, which will allow for more precise debugging for different python versions.
  4. Some settings related to code linting were added during Migrate setup procedures to pyproject.toml #1044 and should not have been as we don't have pre-commit set up for MPAS-Analysis.
  5. We prematurely dropped python 3.9 from CI, so I've added it back.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden
Copy link
Collaborator Author

Testing

I pushed these changes to the develop branch of my fork and confirmed that each of the CI workflows ran successfully.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, this all looks great. I appreciate the PYTHON_VERSION environment variable. That's a good fix.

@xylar xylar merged commit eaedf71 into MPAS-Dev:develop Dec 19, 2024
5 checks passed
@altheaden altheaden deleted the cleanup-code branch December 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants