Migrate setup configurations to pyproject.toml
#1043
Conversation
TestingI was able to create an environment and also build the documentation with this setup without any issues. I'm not sure if there's any additional testing that can be done here, but I'm happy to do it if there is. |
|
I will run the test suite on Chrysalis to make sure things are fine. |
| force_grid_wrap = "0" | ||
| use_parentheses = true | ||
| line_length = "79" | ||
| skip = ["e3sm_diags/e3sm_diags_driver.py"] |
There was a problem hiding this comment.
This can be removed. (Also wherever it got copied from if that's not e3sm_diags, which I suspect is the case.)
There was a problem hiding this comment.
Do you just mean the last line that references e3sm_diags or should the three lines about formatting also be removed?
There was a problem hiding this comment.
I only selected the one line so I don't know why it shows 4. Yes, I just mean the last one. Thanks for asking.
There was a problem hiding this comment.
| skip = ["e3sm_diags/e3sm_diags_driver.py"] |
|
|
||
|
|
||
| "Development Status :: 5 - Production/Stable", | ||
| "License :: OSI Approved :: BSD License", | ||
| "Operating System :: OS Independent", | ||
| "Intended Audience :: Science/Research", | ||
| "Topic :: Scientific/Engineering", |
There was a problem hiding this comment.
Some whitespace issues:
| "Development Status :: 5 - Production/Stable", | |
| "License :: OSI Approved :: BSD License", | |
| "Operating System :: OS Independent", | |
| "Intended Audience :: Science/Research", | |
| "Topic :: Scientific/Engineering", | |
| "Development Status :: 5 - Production/Stable", | |
| "License :: OSI Approved :: BSD License", | |
| "Operating System :: OS Independent", | |
| "Intended Audience :: Science/Research", | |
| "Topic :: Scientific/Engineering", |
There was a problem hiding this comment.
Whoops, looks like I accidentally mixed tabs and spaced. I'll fix that.
| description = """\ | ||
| Analysis for Model for Prediction Across Scales (MPAS) simulations.\ | ||
| """ |
There was a problem hiding this comment.
| description = """\ | |
| Analysis for Model for Prediction Across Scales (MPAS) simulations.\ | |
| """ | |
| description = """\ | |
| Analysis for Model for Prediction Across Scales (MPAS) simulations.\ | |
| """ |
TestingI ran the test suite on this branch. I had no trouble creating the I will double check that all tests complete before merging. |
|
GitHub seems to be glitching. I got an email that you pushed a commit and I can see it directly but it isn't showing up here. |
|
Assuming it's working tomorrow, I'll approve and merge. The changes look great! |
|
Yep, I'm having the same issues. Sounds good! |
This PR moves setup procedures from the
setup.pyandsetup.cfgworkflow to a singlepyproject.tomlfile.Checklist
Testingcomment in the PR documents testing used to verify the changes