Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prt): appease intel fpp, don't name variables 'unix' #1813

Merged
merged 5 commits into from
May 17, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented May 16, 2024

  • intel fortran preprocessor fpp substitutes "1" for "unix" on linux/mac
  • update options
    • move zeromethod option to prp, rename to dev_exit_solve_method
    • add exit_solve_tolerance option
  • update prt autotests and snapshots
  • add comment to brent's root-finding method
  • remove dev_feature blocking prt in SimulationCreate
  • remove prt obs for now, plan to support for next release
  • rename oc option track_transit -> track_exit
  • revise mf6io, regenerate mf6io files

wpbonelli added 5 commits May 16, 2024 21:55
* move zeromethod option to prp and rename to exit_solve_method
* add exit_solve_tolerance option
* update tests and snapshot
* add comment to brent's method
* remove dev_feature blocking prt in SimulationCreate
* remove prt obs for now, support for next release
* revise mf6io, regenerate mf6io files
@wpbonelli wpbonelli marked this pull request as ready for review May 17, 2024 02:53
@wpbonelli wpbonelli merged commit 0fec041 into MODFLOW-USGS:develop May 17, 2024
17 of 18 checks passed
@wpbonelli wpbonelli deleted the prt-var-naming branch May 17, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant