Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): improve release procedure documentation #1620

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

wpbonelli
Copy link
Contributor

  • correct inaccuracies from earlier versions of the release automation
  • describe release notes maintenance procedure
  • rename vx.x.x-template.tex -> vx.y.z-template.tex
  • remove unused function from build_dist.py
  • reformat python scripts in distribution/
  • remove water mover performance entry from develop.tex

* correct inaccuracies from earlier versions of the release automation
* describe release notes maintenance procedure
* rename vx.x.x-template.tex -> vx.y.z-template.tex
* remove unused function from build_dist.py
* reformat python scripts in distribution/
* remove water mover performance entry from develop.tex
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very thorough

@@ -141,19 +124,23 @@ The `--approved` (short `-a`) flag can be used to approve an official release. I

The `--releasemode` flag can be used to control whether binaries are built in development or release mode by editing the contents of `src/Utilities/version.f90`. If the `--releasemode` flag is provided, `IDEVELOPMODE` is set to 0. If `--releasemode` is not provided, `IDEVELOPMODE` is set to 1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify what these are flags to? update_version.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are for update_version.py, edited to clarify that.

@wpbonelli wpbonelli marked this pull request as ready for review February 14, 2024 14:41
@wpbonelli wpbonelli merged commit e31e79b into MODFLOW-USGS:develop Feb 14, 2024
15 checks passed
@wpbonelli wpbonelli deleted the release-docs branch February 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants