Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update SFR diversion flow to zero when its upstream downflow is zero #1467

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

ougx
Copy link
Contributor

@ougx ougx commented Nov 25, 2023

No description provided.

@emorway-usgs emorway-usgs self-assigned this Dec 1, 2023
@emorway-usgs
Copy link
Contributor

emorway-usgs commented Dec 4, 2023

@ougx, I should've caught this earlier, but would you mind updating the release notes to include a brief summary of your fix? You will find a .tex document called "develop.tex" located here: ..\modflow6.git\doc\ReleaseNotes. Under the heading ADVANCED STRESS PACKAGES, it would be helpful to add a new \item that describes the behavior that was happening and what the expected behavior is, and what the fix does to resolve the issue.

Copy link
Contributor

@jdhughes-usgs jdhughes-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is going to have to be rebased against develop if PR #1464 is merged before this one.

@jdhughes-usgs
Copy link
Contributor

@ougx, I should've caught this earlier, but would you mind updating the release notes to include a brief summary of your fix? You will find a .tex document called "develop.tex" located here: ..\modflow6.git\doc\ReleaseNotes. Under the heading ADVANCED STRESS PACKAGES, it would be helpful to add a new \item that describes the behavior that was happening and what the expected behavior is, and what the fix does to resolve the issue.

The fix should be added at

@wpbonelli wpbonelli merged commit 1795124 into MODFLOW-USGS:develop Dec 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants