refactor(fmi): introduce FlowModelInterface module/type, use for gwt #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@w-bonelli, I like this a lot. I'd say go ahead and make sure the PR is up to date, and then let's bring it on in. |
emorway-usgs
added a commit
to emorway-usgs/modflow6
that referenced
this pull request
Sep 14, 2023
…the main code base
emorway-usgs
added a commit
to emorway-usgs/modflow6
that referenced
this pull request
Sep 14, 2023
…the main code base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlowModelInterface.f90, also used by PRT refactor(fmi): minimize fmi, update prt fmi, extend in gwt fmi aprovost-usgs/modflow6#21gwt1fmi1.f90to extendFlowModelInterfaceTypefmi_df()in gwtfmi intogwt_df()in gwt, allows reusing parent fmi define routineTentative — maybe this is not justified and some duplication in gwt and prt fmi is preferable. Adds ~250 loc here, removes ~1200 with PRT, for net savings of ~1000