Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GWE): Groundwater Energy Transport #1237

Closed
wants to merge 278 commits into from

Conversation

emorway-usgs
Copy link
Contributor

Two important areas that need review:

  1. Is the generalized transport (tsp) base class from which gwt and gwe inherit a good idea?
  2. GweGweConnection and GweGweExchange essentially duplicate GwtGwtConnection and GwtGwtExchange, respectively. Perhaps there is a more generalized approach available?

More autotests to follow

emorway-usgs and others added 30 commits July 26, 2022 12:14
…eir input values (e.g., by vsc)

* Added invsc unit number for vsc in gwf
* Added calls to vsc routine (e.g., vsc_ad) from gwf routines
…ting to see if git will figure out the conflicts on its own
* Added store_warning to the list of  SimModule procedures used
* Pending another approach to identifying a temperature "species", commented out the two lines that refer to GwfModelType to avoid circular dependency
… same fixes as what Alden came up with), plus a work around for how to set istmpr (short for "is temperature"; a way to flag that the species being pointed to is infact a temperature species.
# Conflicts:
#	src/Model/GroundWaterFlow/gwf3vsc8.f90
# Conflicts:
#	src/Model/Connection/GwtInterfaceModel.f90
#	src/Model/GroundWaterFlow/gwf3npf8.f90
…6 'develop' branch (stuff in this commit should have been included in the previous commit)
@jdhughes-usgs
Copy link
Contributor

@w-bonelli the makefile should not include any of the parallel files. There is an exclude files option (--excludefiles EXCLUDEFILES), like the extra files --extrafiles EXTRAFILES, for pymake.

@wpbonelli
Copy link
Contributor

wpbonelli commented Jul 21, 2023

@jdhughes-usgs it looks like some parallel files (e.g. src/Solution/PETSc) are already in develop. The build_makefiles.py pymake call for mf6 makefile does use the exclude files option. Should more files be added to pymake/excludefiles.txt?

@jdhughes-usgs
Copy link
Contributor

@jdhughes-usgs it looks like some parallel files (e.g. src/Solution/PETSc) are already in develop. The build_makefiles.py pymake call for mf6 makefile does use the exclude files option. Should more files be added to pymake/excludefiles.txt?

I think all of the parallel files that Meson adds if -Dparallel=true should be excluded.

emorway-usgs added a commit to geohackweek/modflow6-tempfork that referenced this pull request Jan 31, 2024
emorway-usgs added a commit to geohackweek/modflow6-tempfork that referenced this pull request Feb 6, 2024
emorway-usgs added a commit to geohackweek/modflow6-tempfork that referenced this pull request Feb 8, 2024
wpbonelli pushed a commit to wpbonelli/modflow6 that referenced this pull request Feb 9, 2024
emorway-usgs added a commit to geohackweek/modflow6-tempfork that referenced this pull request Feb 9, 2024
emorway-usgs added a commit to geohackweek/modflow6-tempfork that referenced this pull request Feb 9, 2024
langevin-usgs pushed a commit that referenced this pull request Feb 9, 2024
* feat(GWE): Introduce Groundwater Energy Transport

* fix typo in meson file

* fix a formating issue that was popping up in an MST autotest

* some legacy line leftover from a botched rebase, possibly

* Need update initial autotest to conform to new autotest standards adopted with #1464

* Start looking for post-rebase breakages

* Get gwfgwe and gwegwe exchanges up-to-date based on #1505

* Code that had been moved to set_active_status in FMI was still present in fmi_fc(). Removing.

* Forgot to remove unused variables after making changes in 4d76729

* Adding another autotest specific to GWE

* Adding another autotest after getting it #1464 compliant

* Compliantizing another new autotest with PR #1464

* Fixes in response to #1493 (comment)

* Fix in response to #1493 (comment)

* Rerunning black in response to #1493 (comment)

* Fix in response to #1493 (comment)

* Made changes to dfn files in response to #1493 (comment) and #1493 (comment) and reran mf6ivar.py, which updated the tex files in this commit

* Fix in response to #1493 (comment)

* remove unnecessary line of script

* Add missing lines to ConnectionBuilder.f90 related to GWE

* Add a GWE vs GWT comparison autotest

* GWE-GWE exchanges now working.  Other clean-up for code uniformity

* Rebrand constant temperature package acronym to CTP

* Missed an import renaming update

* Forgot to remove a now obsolete file due to renaming.

* Rebrand energy storage and transfer package acronym to EST

* Forgot to remove a now obsolete file due to renaming (again)

* Rebrand gwe dispersion package acronym to CND (conduction) since that is the dominant process in heat transport

* Remove gwe-related code from generalized transport code (tsp1.f90 & tsp1ssm1.f90)

* add single-cell test for energy source loading (ESL) package

* Adding energy source loading (ESL) package

* remove unused variable

* fprettify

* Add another ESL autotest

* Adding another autotest that compares gwe to three different analytical solutions from Carslaw & Jaeger (1947)

* Bringing over Stallman autotest from previous GWE PR (#1237)

* Adding streamflow energy transport (SFE) package

* Add autotest for SFE

* Adding lake energy transport (LKE) package. Includes new autotest

* forgot meson update

* Adding multi-aquifer well energy transport (MWE) package. Includes new autotest

* Adding unsaturated-zone energy transport (UZE) package. Includes 2 new autotests

* Attempting to reapply a failing autotest. Unable to discern why it is failing as downloaded contents from its failure are working locally.

* removing troublesome autotest.  Downloaded contents from failed run on Actions doesn't yield the same output that the logs are reporting.  This particular autotest has an analytical solution (and a plot) that might be better shown on the modflow6-examples repo anyway

* Removing a file that shouldn't have been added (snuck in among other staged files)

* Update release notes
@emorway-usgs
Copy link
Contributor Author

This PR has effectively been replaced with #1306 and #1493. Closing...

@emorway-usgs emorway-usgs deleted the gwe branch August 3, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants