Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(netcdf): windows extended build and tests #2037

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Oct 15, 2024

Add CI testing for windows based netcdf and extended builds:
-- NetCDF-C (4.9.2) pre-compiled libraries used to build fortran libraries
-- NetCDF-Fortran libraries built from source (4.6.1) with ifort and cmake
-- Modflow 6 builds and tests added for netcdf only and parallel + netcdf (extended)
-- release workflow update replaces windows parallel with extended build

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@mjreno mjreno marked this pull request as draft October 15, 2024 21:15
@mjreno mjreno marked this pull request as ready for review November 1, 2024 20:25
Copy link

@christianlangevin christianlangevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjreno, I've looked through this and think it looks great. It will be nice to see how stable it is over time. I think this extended build is a key part for moving all this forward, so many thinks for getting this up and running.

@mjr-deltares
Copy link
Contributor

Nice Job @mjreno ! I am working on fixing the builds on macos in PR #2044 and will ping you when we are good to go

Copy link
Contributor

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests run a separate parallel, netcdf, and extended build. Should we release these as separate distributions, or is the extended build going to replace the parallel build? In either case flopy's get-modflow script will need a change here https://github.com/modflowpy/flopy/blob/9349a07e910095ca501c32106fbb50087c679668/flopy/utils/get_modflow.py#L38 and below on line 71 to handle the new cases.

@mjr-deltares
Copy link
Contributor

It looks like the tests run a separate parallel, netcdf, and extended build. Should we release these as separate distributions, or is the extended build going to replace the parallel build? In either case flopy's get-modflow script will need a change here https://github.com/modflowpy/flopy/blob/9349a07e910095ca501c32106fbb50087c679668/flopy/utils/get_modflow.py#L38 and below on line 71 to handle the new cases.

I think that extended replaces parallel. @jdhughes-usgs agree?

@jdhughes-dev
Copy link
Contributor

It looks like the tests run a separate parallel, netcdf, and extended build. Should we release these as separate distributions, or is the extended build going to replace the parallel build? In either case flopy's get-modflow script will need a change here https://github.com/modflowpy/flopy/blob/9349a07e910095ca501c32106fbb50087c679668/flopy/utils/get_modflow.py#L38 and below on line 71 to handle the new cases.

I think that extended replaces parallel. @jdhughes-usgs agree?

I agree. We probably also need to look for either ext or par so older versions can be downloaded.

@mjr-deltares mjr-deltares merged commit d12df58 into MODFLOW-ORG:develop Nov 5, 2024
26 checks passed
wpbonelli added a commit to jdhughes-dev/GW3099-2024 that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants