-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(netcdf): windows extended build and tests #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjreno, I've looked through this and think it looks great. It will be nice to see how stable it is over time. I think this extended build is a key part for moving all this forward, so many thinks for getting this up and running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the tests run a separate parallel, netcdf, and extended build. Should we release these as separate distributions, or is the extended build going to replace the parallel build? In either case flopy's get-modflow script will need a change here https://github.com/modflowpy/flopy/blob/9349a07e910095ca501c32106fbb50087c679668/flopy/utils/get_modflow.py#L38 and below on line 71 to handle the new cases.
I think that extended replaces parallel. @jdhughes-usgs agree? |
I agree. We probably also need to look for either |
Add CI testing for windows based netcdf and extended builds:
-- NetCDF-C (4.9.2) pre-compiled libraries used to build fortran libraries
-- NetCDF-Fortran libraries built from source (4.6.1) with ifort and cmake
-- Modflow 6 builds and tests added for netcdf only and parallel + netcdf (extended)
-- release workflow update replaces windows parallel with extended build
Checklist of items for pull request
ruff
on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.For additional information see instructions for contributing and instructions for developing.