Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the command to a different package in packages/cli-hermes #9

Merged
merged 5 commits into from
Aug 18, 2020

Conversation

jessieAnhNguyen
Copy link
Member

Summary:


Test Plan:


  • Test it by linking the packages as guided on Testing guide
  • As we add a new package, add this into the list of linked packages "@react-native-community/cli-hermes"
  • The result still looked like before
    image

@jessieAnhNguyen jessieAnhNguyen self-assigned this Aug 18, 2020
@jessieAnhNguyen jessieAnhNguyen linked an issue Aug 18, 2020 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@jevakallio jevakallio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One small add, can you also add the new cli-hermes package to the yarn link list of packages in the Contributing documentation here:
https://github.com/MLH-Fellowship/cli/blob/master/CONTRIBUTING.md#yarn-v1

@jessieAnhNguyen jessieAnhNguyen merged commit e53ee19 into master Aug 18, 2020
@jessieAnhNguyen jessieAnhNguyen deleted the movePackage branch August 18, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the command to its own package
3 participants