Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hexadecimal numbers #19

Closed
XVilka opened this issue Jul 26, 2019 · 4 comments
Closed

Support hexadecimal numbers #19

XVilka opened this issue Jul 26, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@XVilka
Copy link
Contributor

XVilka commented Jul 26, 2019

So this would work

byte_alphanum(B, R) :-
    B > 0x2f, B < 0x3b, R = true.
@VincentDerk VincentDerk added the enhancement New feature or request label Jul 26, 2019
@XVilka
Copy link
Contributor Author

XVilka commented Aug 9, 2019

Is it possible to implement it? It is very annoying to convert every number just for the Problog, since the rest of interpreters work just fine.

@VincentDerk
Copy link
Collaborator

Unfortunately, me personally, I am very busy in the next couple of weeks so I won't be able to. We're happy to take pull requests.

@anton3s
Copy link
Collaborator

anton3s commented Aug 13, 2019

I've created a pull request which fixes this issue. It's running through the checks...

@VincentDerk
Copy link
Collaborator

Merged it, thanks!

VincentDerk added a commit that referenced this issue Jun 29, 2022
@VincentDerk
Merge pull request #19 from ML-KULeuven/develop
7663525 
Mainly bugfixes, but we also changed the Term's hashing method. If this proofs to be worse, we may reconsider switching back later.

* Bugfix library/string.py::str2lst (public issue #84)
* Bugfix return exit code instead of result - only for probability task atm (public issue #82)
* Critical Bugfix in dSharp library (compiled CNF theory with too long clauses could yield wrong result)
* Bugfix in pypl related to lists (private issue #16)
* Minor improvements to LFI
* Changed Term's hashing method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XVilka @anton3s @VincentDerk