-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xarray master ci #248
Conversation
Thanks so much for this fix @timothyas!
👍 to both!
Maybe we would have to update setup.py in some places. |
Generally speaking, there is no reason for us to be more conservative with our dependencies than Xarray. We can just follow what Xarray does in terms of python version support. |
No problem!
That definitely makes sense. I'll get to this as soon as I can :) |
d6521ef
to
559d39f
Compare
Ok I just finished:
I think it's good to go for whenever you get the chance to check it out. |
LGTM! |
* py36->py37 for latest xarray * filename * drop ci for 2.7, 3.6. Add 3.9 * update url, drop 2-3.6 * specify python>=3.7 * update dependencies in docs/readme
Simply update CI workflow to use python 3.7, which xarray master now requires.
Should we drop python 2.7? phase out 3.6? I'd be happy to do that here, but not sure what it entails other than:
It is maybe not critical to remove stuff like:
But this would clean things up. I'm curious what you think.