Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xarray master ci #248

Merged
merged 6 commits into from
Jan 19, 2021
Merged

Conversation

timothyas
Copy link
Member

@timothyas timothyas commented Jan 10, 2021

Simply update CI workflow to use python 3.7, which xarray master now requires.

Should we drop python 2.7? phase out 3.6? I'd be happy to do that here, but not sure what it entails other than:

  • drop the CI workflows
  • remove from README etc

It is maybe not critical to remove stuff like:

if (sys.version_info < (3,0):
    do something

But this would clean things up. I'm curious what you think.

@rabernat
Copy link
Member

Thanks so much for this fix @timothyas!

Should we drop python 2.7? phase out 3.6?

👍 to both!

not sure what it entails

Maybe we would have to update setup.py in some places.

@rabernat
Copy link
Member

Generally speaking, there is no reason for us to be more conservative with our dependencies than Xarray. We can just follow what Xarray does in terms of python version support.

@timothyas
Copy link
Member Author

No problem!

Generally speaking, there is no reason for us to be more conservative with our dependencies than Xarray. We can just follow what Xarray does in terms of python version support.

That definitely makes sense. I'll get to this as soon as I can :)

@timothyas timothyas force-pushed the update_xarray_master_ci branch from d6521ef to 559d39f Compare January 13, 2021 16:44
@timothyas
Copy link
Member Author

Ok I just finished:

  • updating the URL and dependencies in setup.py: specified python>=3.7 in setup, and xarray >=0.11.0 since this is when they introduced python 3.7
  • updated versions of python, xarray, dask in readme and installation documentation
  • drop CI for 2.7, 3.6, add CI for 3.9

I think it's good to go for whenever you get the chance to check it out.

@rabernat
Copy link
Member

LGTM!

@rabernat rabernat merged commit b6eb223 into MITgcm:master Jan 19, 2021
@timothyas timothyas deleted the update_xarray_master_ci branch January 19, 2021 16:39
fraserwg pushed a commit to fraserwg/xmitgcm that referenced this pull request Nov 23, 2021
* py36->py37 for latest xarray

* filename

* drop ci for 2.7, 3.6. Add 3.9

* update url, drop 2-3.6

* specify python>=3.7

* update dependencies in docs/readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants