python 2.7 env with old zarr #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Tim! Can we just drop python 2 going forward for xmitgcm? Or maybe make a release now and then drop on the next release? |
|
Hmm, I'm not sure what is best so I'll leave that to you. Dropping python 2 would be fine with me, would that just involve removing python 2.7 tests and dropping it from setup? Happy to move forward with either. |
|
Let's merge this, release 0.5.0, and then drop python 3 for 0.6. |
fraserwg
pushed a commit
to fraserwg/xmitgcm
that referenced
this pull request
Nov 23, 2021
* attempt to fix py27 with old zarr * alternate soln with setup * didn't work, back to first soln
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current python 2.7 tests break because of zarr, which has not supported python 2 since version 2.3.2. This PR specifies
zarr<=2.3.2in the ci/environment file.