Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST returning suggested resources #1348

Closed
wants to merge 8 commits into from
Closed

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Sep 6, 2024

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

@mitlib mitlib temporarily deployed to mit-bento-pr-1348 September 6, 2024 17:01 Inactive
@jazairi jazairi temporarily deployed to mit-bento-pr-1348 September 6, 2024 17:04 Inactive
Drop table, remove additional code missed from last commit
@jazairi jazairi temporarily deployed to mit-bento-pr-1348 September 6, 2024 17:12 Inactive
@coveralls
Copy link

coveralls commented Sep 6, 2024

Coverage Status

coverage: 97.545% (-1.7%) from 99.216%
when pulling ea719e3 on tco-66-hints-to-tacos
into fcb079f on main.

@jazairi jazairi temporarily deployed to mit-bento-pr-1348 September 6, 2024 17:29 Inactive
@jazairi jazairi temporarily deployed to mit-bento-pr-1348 September 6, 2024 18:22 Inactive
@jazairi jazairi temporarily deployed to mit-bento-pr-1348 September 6, 2024 20:19 Inactive
@jazairi jazairi closed this Sep 9, 2024
@jazairi jazairi deleted the tco-66-hints-to-tacos branch September 9, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants