Adds panel for NPS surveys #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
I realize it's a bit unorthodox for me to review this as a contributor. We can loop Matt in if it would be useful to get fresh eyes on it.
The last two commits are small refactors to the SCSS. They were quick enough that it made sense just to push up the changes rather than comment. I'd suggest taking a quick look before merging to make sure everything makes sense sense. (It's been a long day, and I wouldn't trust my code at this juncture.)
The only tangible change to the stylesheet is moving the font color from #fff to $white, which is a very slight off-white. The brand also provides $white-t if true white is what is needed here, but $white did not present any contrast issues in WAVE.
Why are these changes being introduced: * UX has requested this to gather feedback from users Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/PW-102 How does this address that need: * Creates display panel that is configured via ENV to allow for making changes to content without redeploys of code Document any side effects to this change: * Added some newish sqlite files to gitignore
Stephanie and I paired today to fine-tune the design a bit. The goals of the session were to fix the padding, reduce the font size in large viewports, and ensure that the text didn't wrap beyond two lines in smaller viewports. We made the following changes: * Removes `copy-lead` and `box-content` classes. * Sets padding to `20px 10px`. * Sets font-size to `$fs-large` (20px) at viewport widths larger than our medium breakpoint, and `$fs-base` (16px) at smaller widths. * Explicitly sets `display: block`. (This rule is implied/inherited, but it felt useful to declare it because inline-block does weird things.) Other things we tried but decided not to do: * Put `display: block` and `text-wrap: nowrap` on the link in smaller viewports. This mostly looked good, but squeezed the spacing from the sides. * Leave the font size as `$fs-large` in smaller viewports. We were able to do this without wrapping by reducing the padding, but it was visually out of proportion. Co-authored-by: Stephanie Hartman <[email protected]>
JPrevost
force-pushed
the
pw102-nps-banner
branch
from
c7968ba to
42b63b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO