Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy ricker wavelet from scipy which removed it from version 1.15.0 #526

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

wenh06
Copy link
Contributor

@wenh06 wenh06 commented Jan 16, 2025

This PR fixes issue #525

@tompollard
Copy link
Member

Thanks @wenh06! If copying, we need to make sure that we follow the license terms, which I think are here: https://github.com/scipy/scipy/blob/main/LICENSE.txt

Alternatively, we could add a dependency on the recommended package: https://pywavelets.readthedocs.io/en/latest/

@wenh06
Copy link
Contributor Author

wenh06 commented Jan 18, 2025

The ricker wavelet is defined as

$$ \psi (t)={\frac {2}{{\sqrt {3\sigma }}\pi ^{1/4}}}\left(1-\left({\frac {t}{\sigma }}\right)^{2}\right)e^{-{\frac {1}{2} \left({\frac {t}{\sigma }}\right)^{2}}} $$

But pywt seems to fix $\sigma = 1$, I don't know how to change this parameter with pywt.

@tompollard
Copy link
Member

Looks good to me, thanks again @wenh06

@tompollard tompollard merged commit d8b620c into MIT-LCP:main Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants