Avoid ambiguous backslashes in regular expression strings #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tompollard found that ambiguous backslashes give DeprecationWarnings on his system.
(Not that I think there is any danger of this behavior changing in python, but I think it's fair to say this syntax is confusing and should be avoided.)
I.e.:
"\s\n"
is a three-character string (equal to"\\s\n"
). If what you mean is"\\s\n"
, it's better to write that and be unambiguous.r"\s\n"
is a four-character string ("\\s\\n"
) but is interpreted byre.compile
as equivalent to"\\s\n"
. So when writing regular expression patterns it's best to user
strings if possible.