Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This updates the Matplotlib version to avoid segmentation faults on Macs running Big Sur. #310

Merged
merged 2 commits into from
Jun 22, 2021
Merged

This updates the Matplotlib version to avoid segmentation faults on Macs running Big Sur. #310

merged 2 commits into from
Jun 22, 2021

Conversation

briangow
Copy link
Contributor

Fixes #309

@tompollard
Copy link
Member

tompollard commented Jun 22, 2021 •
edited
Loading

Thanks @briangow. This change updates the version used for installing the development environment but to fix the bug for people pip installing the package we should update https://github.com/MIT-LCP/wfdb-python/blob/master/setup.py

@briangow
Copy link
Contributor Author

Thanks @tompollard! I've updated the setup.py file.

@tompollard
Copy link
Member

Looks good, thanks!

@tompollard tompollard merged commit 5bb2e3c into master Jun 22, 2021
@tompollard tompollard deleted the seg_fault branch June 22, 2021 14:20
@tompollard tompollard restored the seg_fault branch June 22, 2021 14:20
@tompollard tompollard deleted the seg_fault branch June 22, 2021 14:21
@tompollard tompollard mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault on Mac with older version of Matplotlib
2 participants
@briangow @tompollard