Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix norepinephrine in PSQL, tidy vasoactive code #1505

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Fix norepinephrine in PSQL, tidy vasoactive code #1505

merged 3 commits into from
Mar 23, 2023

Conversation

alistairewj
Copy link
Member

tompollard
tompollard approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@tompollard tompollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a quick review, but looks good to me!

mimic-iv/concepts/medication/norepinephrine_equivalent_dose.sql Outdated Show resolved Hide resolved
mimic-iv/concepts_postgres/medication/norepinephrine_equivalent_dose.sql Outdated Show resolved Hide resolved
mimic-iv/concepts_postgres/medication/norepinephrine_equivalent_dose.sql Show resolved Hide resolved
@alistairewj
add comments and formatting for vasoactive meds
773b417
@alistairewj
carry over formatting to postgres scripts
f02600d
@alistairewj
fix: bug where norepinephrine is skipped in output to psql
572233c 
was due to a regex match succeeding against similarly named
norepinephrine_equivalent_dose. fix was to change to exact
matching with grep. re-ran to regenerate psql concepts.
fixed #1494
@alistairewj alistairewj merged commit 04a11ba into main Mar 23, 2023
@alistairewj alistairewj deleted the tidy_ned_sql branch March 23, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompollard tompollard tompollard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistairewj @tompollard