MIMIC-IV MySQL build script update #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairewj
force-pushed
the
mimic_iv_mysql_fixes
branch
from
9ccda20 to
bce26c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from a re-run of csv2mysql from @pszolovits - looks to add more info in comments, modify data types modestly (e.g. unsigned int to int, and some small ints to medium ints) - some seem like they will result in performance improvements (e.g. a
TEXTfield converted toVARCHAR(255)in emar_detail).I've also added a GitHub action for building the demo in mysql but it will likely fail since I just tried to write it blindly.. so PR is still a draft.