不動産IDの読み込み対応 #120
Merged
不動産IDの読み込み対応 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthroughこの変更では、 Changes
Assessment against linked issues
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- plateau_plugin/metadata.txt (1 hunks)
- plateau_plugin/plateau/models/init.py (2 hunks)
- plateau_plugin/plateau/models/building.py (3 hunks)
Additional comments: 6
plateau_plugin/metadata.txt (1)
- 3-3: バージョンが0.0.5から0.0.6に正しく更新されています。新機能や改善の追加に伴うバージョンアップであることがわかります。
plateau_plugin/plateau/models/__init__.py (2)
- 27-27:
REAL_ESTATE_ID_ATTRIBUTEが正しく追加されています。これにより、不動産ID属性に関連するデータの処理とエクスポートが可能になります。- 85-85:
REAL_ESTATE_ID_ATTRIBUTEがプロセッサレジストリに正しく登録されています。これにより、不動産ID属性のサポートが強化されます。plateau_plugin/plateau/models/building.py (3)
- 21-21: 新しい属性パス
uro:bldgRealEstateIDAttributeが正しく追加されています。これにより、建物要素内のuro:RealEstateIDAttributeを認識し処理することが可能になります。- 154-169:
real_estate_id_pathに関連するセクションがコメントアウトされています。この変更の背景や将来の計画について、もう少し詳細を共有していただけますか？- 724-767:
uro:RealEstateIDAttributeのための新しい特徴処理定義が追加されました。これにより、不動産ID属性の非幾何学的処理が可能になり、プラグイン内での不動産データの取り扱いが強化されます。
ciscorn
requested changes
Mar 18, 2024
Comment on lines
154
to
169
| # real_estate_id_attr_container_path="./uro:bldgRealEstateIDAttribute", # 不動産ID | ||
| dm_attr_container_path="./uro:bldgDmAttribute", | ||
| facility_attr_paths=FacilityAttributePaths( | ||
| facility_id="./uro:bldgFacilityIdAttribute", | ||
| facility_types="./uro:bldgFacilityTypeAttribute", | ||
| facility_attrs="./uro:bldgFacilityAttribute", | ||
| large_customer_facility_attrs="./uro:largeCustomerFacilityAttribute", | ||
| ), | ||
| # real_estate_id_path = RealEstateIDAttributePaths( # uro:bldgRealEstateIDAttribute/aaa | ||
| # real_estate_id_of_building = "./uro:realEstateIDOfBuilding", | ||
| # number_of_building_unit_ownership= "./uro:numberOfBuildingUnitOwnership", | ||
| # real_estate_id_of_building_unit_ownership = "./uro:realEstateIDOfBuildingUnitOwnership", | ||
| # number_of_real_estate_id_of_Land = "./uro:numberOfRealEstateIDOfLand", | ||
| # real_estate_id_of_land = "./uro:realEstateIDOfLand", | ||
| # matchingS_score = "./uro:matchingScore", | ||
| # ), |
There was a problem hiding this comment.
ありがとうございます。
このあたりのコメントアウトは削除忘れでしょうか？！
その他はLGTMです
There was a problem hiding this comment.
お、消し忘れでした。。コメントアウト削除してマージしちゃいます！
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- plateau_plugin/plateau/models/building.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- plateau_plugin/plateau/models/building.py
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- plateau_plugin/plateau/models/init.py (2 hunks)
- plateau_plugin/plateau/models/building.py (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- plateau_plugin/plateau/models/init.py
- plateau_plugin/plateau/models/building.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #104
Summary by CodeRabbit
0.0.5から0.0.6へ更新され、日本で使用される CityGML 形式の3D都市モデルデータのインポート機能が強化されました。REAL_ESTATE_ID_ATTRIBUTEを追加しました。uro:bldgRealEstateIDAttributeを追加し、uro:RealEstateIDAttributeに関する新しい機能処理定義を導入しました。