Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integral length scale function #376

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Feb 6, 2025

Discovered a problem with the original function while conducting data analysis of ADV data from Puget Sound.

Updating this function per the textbook definition of the integral time scale - it is listed as Equation 5.3 in this paper (http://dx.doi.org/10.1098/rsta.2012.0196). The code I'm replacing defined the integral time scale as when the autocorrelation function decays to 1/e of its original value, which is less robust than finding the first zero-crossing of the autocorrelation function, as is standard.

The integral length scale [m] is simply the average flow speed [m/s] multiplied by the integral time scale [s].

Copy link
Contributor

@ssolson ssolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcvey3 theses changes are good to go once the tests pass.

I saw you started all 4 PR checks at the same time yesterday which will cause the APIs to fail.

I restarted just this one for now and hope it will pass and we can get this merged here in the next couple hours.

@jmcvey3 jmcvey3 merged commit 7c45c96 into MHKiT-Software:develop Feb 17, 2025
42 of 43 checks passed
@jmcvey3 jmcvey3 deleted the length-scales branch February 17, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants