Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHKiT Python 3.12 support #351

Merged
merged 8 commits into from
Sep 11, 2024
Merged

MHKiT Python 3.12 support #351

merged 8 commits into from
Sep 11, 2024

Conversation

ssolson
Copy link
Contributor

@ssolson ssolson commented Sep 4, 2024

Adds Python 3.12 as a supported version.

Required installing setup tools for pip installs due to hypyd. This has been fixed but not released to pypi yet:
HDFGroup/h5pyd#169
Once a new release of h5pyd to pypi happens we should remove this step.

@ssolson ssolson changed the title Python 3.12 MHKiT Python 3.12 support Sep 6, 2024
@ssolson ssolson self-assigned this Sep 6, 2024
@ssolson ssolson added the enhancement New feature or request label Sep 6, 2024
@ssolson ssolson marked this pull request as ready for review September 6, 2024 15:20
@ssolson ssolson requested a review from akeeste September 6, 2024 15:20
@akeeste
Copy link
Contributor

akeeste commented Sep 6, 2024

Thanks @ssolson

Is setuptools only required for the test environment or for MHKiT generally using Python 3.12? If the former, let's merge this now. If the latter, let's wait until our next release is closer and see if h5pyd has this fix on pypi then

@ssolson
Copy link
Contributor Author

ssolson commented Sep 6, 2024

Thanks @ssolson

Is setuptools only required for the test environment or for MHKiT generally using Python 3.12? If the former, let's merge this now. If the latter, let's wait until our next release is closer and see if h5pyd has this fix on pypi then

It is the latter, however, as this is the development branch I think developing all PRs for 3.12 support now would be beneficial rather than trying to fix any potential issues later.

@ssolson
Copy link
Contributor Author

ssolson commented Sep 6, 2024

I want to wait on #333 to be merged before this PR.

@akeeste
Copy link
Contributor

akeeste commented Sep 6, 2024

It is the latter, however, as this is the development branch I think developing all PRs for 3.12 support now would be beneficial rather than trying to fix any potential issues later.

Fair point, that makes sense to avoid a bunch of urgent bugfixes right before we want to tag a release. Understood on timing this relative to #333. Tests pass on 3.12.

I successfully created a 3.12 environment with MHKiT locally, but FYI I did get a pip deprecation warning when using the editable install (pip install -e .) This method will not be supported in pip>=25.0 and will require another method. Not a chance required in this PR, but will be an upcoming issue in the future.

@ssolson ssolson merged commit d364d56 into MHKiT-Software:develop Sep 11, 2024
41 checks passed
@ssolson ssolson deleted the py312 branch September 11, 2024 12:43
@ssolson ssolson mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants