-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHKiT v0.8.1 #337
MHKiT v0.8.1 #337
Conversation
* fix ipynb notebooks * update links in noaa.py * clean up module docstrings * add notebook and python <3.12 to dependencies * update variable naming in hindcast.py * move notebook to a pip install in yaml file * update np.product to np.prod per the depreciation warning * fix type checking in wave.performance capture length and maep matrix * fix valueerror in tidal.graphics * slight speedup for utils.type_handling * revert minor utils type_handling change * revert dataarray conversion in power_performance_workflow * fix mooring test --------- Co-authored-by: ssolson <[email protected]>
* no np 2.0 * v0.8.1 * fix python versions description * netcdf <=1.6.5
@akeeste are you around today to review this minor update? |
@ssolson yes I can review this morning. the changes are pretty straight forward since it's just 2 recent PRs. I will test a couple things locally and look into the failing test |
The test failure looks like an Actions issue. I'm really hoping it just passes on a rerun. This just passed in the previous PR. We are also dropping 3.8 support soon, soo personally I'm less concerned with this test failing versus getting fresh installs of MHKiT to work for everyone ASAP. Exact same commit where the current failure passes: |
Good to know. I'm not too worried about the one-off failure then since the other instance passed. The hindcast tests are really bogging us down... I'm looking into this today |
All tests passed on re-run. |
MHKiT v0.8.1
MHKiT v0.8.1, includes bug fixes in the example notebooks and fixes the dependencies to requirements updates prior to Numpy 2.0.0.
Fixes MHKIT v0.8.0 installation issues (#334) by fixing the dependencies.
Fixes bugs in MHKiT example notebooks