Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHKiT v0.8.1 #337

Merged
merged 2 commits into from
Jun 30, 2024
Merged

MHKiT v0.8.1 #337

merged 2 commits into from
Jun 30, 2024

Conversation

ssolson
Copy link
Contributor

@ssolson ssolson commented Jun 28, 2024

MHKiT v0.8.1

MHKiT v0.8.1, includes bug fixes in the example notebooks and fixes the dependencies to requirements updates prior to Numpy 2.0.0.

Fixes MHKIT v0.8.0 installation issues (#334) by fixing the dependencies.

Fixes bugs in MHKiT example notebooks

akeeste and others added 2 commits June 18, 2024 06:32
* fix ipynb notebooks

* update links in noaa.py

* clean up module docstrings

* add notebook and python <3.12 to dependencies

* update variable naming in hindcast.py

* move notebook to a pip install in yaml file

* update np.product to np.prod per the depreciation warning

* fix type checking in wave.performance capture length and maep matrix

* fix valueerror in tidal.graphics

* slight speedup for utils.type_handling

* revert minor utils type_handling change

* revert dataarray conversion in power_performance_workflow

* fix mooring test

---------

Co-authored-by: ssolson <[email protected]>
* no np 2.0

* v0.8.1

* fix python versions description

* netcdf <=1.6.5
@ssolson ssolson added the deprecation Code is deprecated and needs to be updated label Jun 28, 2024
@ssolson ssolson self-assigned this Jun 28, 2024
@ssolson
Copy link
Contributor Author

ssolson commented Jun 28, 2024

@akeeste are you around today to review this minor update?

@ssolson ssolson requested a review from akeeste June 28, 2024 13:51
@akeeste
Copy link
Contributor

akeeste commented Jun 28, 2024

@ssolson yes I can review this morning. the changes are pretty straight forward since it's just 2 recent PRs. I will test a couple things locally and look into the failing test

@ssolson
Copy link
Contributor Author

ssolson commented Jun 28, 2024

@ssolson yes I can review this morning. the changes are pretty straight forward since it's just 2 recent PRs. I will test a couple things locally and look into the failing test

The test failure looks like an Actions issue. I'm really hoping it just passes on a rerun. This just passed in the previous PR. We are also dropping 3.8 support soon, soo personally I'm less concerned with this test failing versus getting fresh installs of MHKiT to work for everyone ASAP.

Exact same commit where the current failure passes:
https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/9707092669

@ssolson
Copy link
Contributor Author

ssolson commented Jun 28, 2024

Actually you can see the test passed on PR but failed on push. I need to adjust the actions in the future so it only does PR or push not both to master

image

@akeeste
Copy link
Contributor

akeeste commented Jun 28, 2024

Actually you can see the test passed on PR but failed on push. I need to adjust the actions in the future so it only does PR or push not both to master

image

Good to know. I'm not too worried about the one-off failure then since the other instance passed. The hindcast tests are really bogging us down... I'm looking into this today

@ssolson
Copy link
Contributor Author

ssolson commented Jun 30, 2024

All tests passed on re-run.

@ssolson ssolson merged commit 24674f1 into master Jun 30, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Code is deprecated and needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants