-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating virtual buoy results based on updated data #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ssolson nothing changed at all in the code, just the data changed. Hopefully this passes CI |
What is weird is that python 3.7, 3.8 passed last time. This passed so yeah I will merge to hopefully remove/ update the fail badge status to pass. |
As an answer to your comment it was only the 1-hour data that changed. Python 3.7 and 3.8 are testing 3-hour data requests. |
ssolson
added a commit
that referenced
this pull request
Feb 1, 2022
* delft 3d ploting function * d3d flume data * Reorganized headers * Change Headers (#1) * changing path to data following organizational update * Reorganized headers Co-authored-by: rpauly18 <[email protected]> Co-authored-by: rpauly18 <[email protected]> * center line section * center line update * Add manual interpolation of variable * automated interpolation * adding xarray * Used dataframe for slicing * 3d interpolation in progress * added y interpolation * interpolation looping fixed * added z interpolation to centerline plots * added z interpolation * d3d with interpolation for irregular grid * psuedo code for new function get_variable_points * psuedo code for new function get_variable_points (#4) * plots center line plot for input points * added DataFrames * updated doc string * added creat_points code for a contour plot * updated creat_points centerlinea nd point logic * adding plot def, still has errors * Add files via upload * finged plotting isses * fixed plotting * changed d3d.irregualar_grids to d3d.py * added turbulence layers in get_all_data_points def * added turbulent intensity def * unneeded file * updated turbulent intensity * added unorm function and Turbulent intensity defal * updated labeling * Add Undefined points code (#5) * delft 3d ploting function * d3d flume data * Reorganized headers * Change Headers (#1) * changing path to data following organizational update * Reorganized headers Co-authored-by: rpauly18 <[email protected]> Co-authored-by: rpauly18 <[email protected]> * center line section * center line update * Add manual interpolation of variable * automated interpolation * adding xarray * Used dataframe for slicing * 3d interpolation in progress * starting with minimal try/except statement * added y interpolation * interpolation looping fixed * added z interpolation to centerline plots * added z interpolation * d3d with interpolation for irregular grid * psuedo code for new function get_variable_points * psuedo code for new function get_variable_points (#4) * unknown changes * adding warning * retrying build * removing warning * trying new key * editing .hscfg file * trying a different os * trying mac and windows * adding nose install to windows * modifting nostest call for windows * undoing last commit * trying pytest * try again * plots center line plot for input points * added DataFrames * reverting travis yml and upgrading h5pyd * fixing typo * re-adding warning message * updated doc string * added creat_points code for a contour plot * updated creat_points centerlinea nd point logic * updating virtual buoy results based on updated data (#107) * adding plot def, still has errors * Add files via upload * finged plotting isses * fixed plotting * changed d3d.irregualar_grids to d3d.py * added turbulence layers in get_all_data_points def * added turbulent intensity def * unneeded file * updated turbulent intensity * added unorm function and Turbulent intensity defal * updated labeling * Psuedo code for undefined points Co-authored-by: browniea <[email protected]> Co-authored-by: rpauly18 <[email protected]> Co-authored-by: rpauly18 <[email protected]> Co-authored-by: Emily Browning <[email protected]> Co-authored-by: Browning <[email protected]> * added assert statments * added ploting script to run d3d.py * updated bottom depth to be interpolated for wdir grid * added d3d function * updated file structure and bottom depth interpolation * changed name from io.py * updated file stucture * moved file to io folder under usgs.py * updated import statments * added assert statments * starting test * added test for d3d code * added new grid function * updated plots * added test for d3d.py * minor changes to fix test * removed plots_d3d * fixed file path to be compatable with lynix and apple os * made sugested revisions * removed old d3d file * undated testdir in line 14 * Add files via upload Adding the Flume data * chnaged file diretery to pull mane with __file__ * updated labels * added flume data * updated variable names * adding the example case for d3d.py code * fixed variable name in grid_data function * add d3d io funtions to tidal module * updated discriptions of d3d_example * made eddits to markdown discriptions * changed function outputs from arrays to DataFrames * updated test to take dataframe inputs * updated for dataframe outputs * updated for dataframe output updated * added boolian input to turbulnet_intesity fuction * fixed assert statment in turbulen_intesity function * fixed boolian input to turbulent intensity * fixed Turbulent intesity function * updated test_turbulent_intesity * fixed turbulent_intesity function for points= 'cells' input * updated grid_data for cells input * updated tunbulent_intesity function to nan negative values * updated turbulent_intesity examples * updated contour plots * changed grid_data to variable_interpolation * updated Turbulent_intesity negative filter to replace with 0 * added to the variable_interpolation block * updated assert statment and negative number filter on turbulent function * deleted old flume data * added to the variable_interpolation discription * added time steps (5) * fixed revewer comments * changed example data to turbineTest_map.nc * updated graph font size * Rename Delft3d_example.ipynb to Delft3D_example.ipynb * updated code for plot labels * updated spacing * updated code for plot formating * updated plot labels and limmits * updated formating * Delete turbineTest_map.nc will re-upload * will add back * add d3d example data folder * updated doc strings * deleting backup * deleting backup * updated spacing on doc strings * addressed some of @rpauly18 comments * made @rpauly18 sujested edits * added more inline comments * added more inline comments * fixed bug in create_points * added more inline code discriptions * updated discription of creat_points * fixed spelling on inline code comments * typo correction and cleanup * added examples * added unom function * add unorm function * removed unorm and improted from utils * added a few discrip discriptave details * added spaces on line 940 to reupload file * removed previous changes Co-authored-by: ssolson <[email protected]> Co-authored-by: ssolson <[email protected]> Co-authored-by: rpauly18 <[email protected]> Co-authored-by: rpauly18 <[email protected]> Co-authored-by: Browning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1 hour data was updated on AWS. Different buoy locations are now in it- so the data changed with the request. The data we are comparing to has been updated accordingly.