Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Wind hindcast API Calls #315

Closed
ssolson opened this issue Apr 26, 2024 · 4 comments
Closed

CI: Wind hindcast API Calls #315

ssolson opened this issue Apr 26, 2024 · 4 comments
Assignees
@akeeste
Labels
Clean Up Improve code consistency and readability

Comments

@ssolson
Copy link
Contributor

ssolson commented Apr 26, 2024 •
edited
Loading

The wind hindcast data currently takes greater than 3.5 hours to collect the needed data.

Can we get this down to 1 hr to be on par with the wave data?

image
@ssolson ssolson mentioned this issue May 5, 2024
Merged
@akeeste
Copy link
Contributor

akeeste commented May 17, 2024

The metocean example pulls wind toolkit data and is pretty fast. We should look at replacing our test data with what's used in that example

@akeeste
Copy link
Contributor

akeeste commented Jun 28, 2024 •
edited
Loading

I'm attempting to look into this today. I started testing locally but it seems like I'm already being rate limited.

My initial testing indicates that multiparameter requests are running as expected (the metocean example only does this), but for some reason multiyear and multilocation requests are very slow. I'll keep investigating this today and next week as the NREL server allows

@akeeste akeeste mentioned this issue Jul 2, 2024
Merged
3 tasks
@akeeste
Copy link
Contributor

akeeste commented Jul 2, 2024

Hopefully #315 shows some performance improvements. But in the typical manner of pulling this data, it was successful once locally and then downloads started hanging for long times.

@ssolson ssolson added the Clean Up Improve code consistency and readability label Jul 22, 2024
ssolson pushed a commit that referenced this issue Aug 8, 2024
@akeeste
Speed up Wind Toolkit tests (#338)
fec6c2e 
This PR addresses #315 by:
- Changes the data called by the Wind Toolkit tests so that they run faster
- Updates the .csv files that the tests compare against
- Updates a few descriptions in the metocean example, fixes a sorting issue, reduces the data downloaded there
- Tests in hindcast match the notebooks and use the same cache.
ssolson pushed a commit that referenced this issue Aug 13, 2024
@akeeste @ssolson
Speed up Wind Toolkit tests (#338)
a52e0c0 
This PR addresses #315 by:
- Changes the data called by the Wind Toolkit tests so that they run faster
- Updates the .csv files that the tests compare against
- Updates a few descriptions in the metocean example, fixes a sorting issue, reduces the data downloaded there
- Tests in hindcast match the notebooks and use the same cache.
@akeeste
Copy link
Contributor

akeeste commented Aug 15, 2024 •
edited
Loading

This issue was addressed by #338. #343 will continue this effort in another direction

@akeeste akeeste closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akeeste akeeste

Labels
Clean Up Improve code consistency and readability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssolson @akeeste