WPTO Hindcast #42
Closed
WPTO Hindcast #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssolson this is ready for review, even though the CI has failed. It fails because it uses pip to install MHKiT-Python, and since the WPTO function is not tagged in a pip release- it cannot run the function. That being said, we will not merge this PR until MHKiT-Python has been tagged with pip, but it would be good to get it reviewed so we can merge it quickly after the pip tag. I will look into if we can change how the Matlab CI gets MHKiT-Python so the tests will work in the future. |
|
This was re-done in #61 allowing for Windows utilization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new WPTO hindcast function to MHKiTMatlab